New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema): test for using a custom AJV with ajv-formats #2513

Merged

daffl merged 4 commits into dove from schema-add-formats

Jan 3, 2022

Member

marshallswain commented Dec 22, 2021 •

edited

Loading

Summary

Adds a test that shows how to use ajv-formats with a custom instance of Ajv. I opted for leaving the ajv-formats package out and created a test that shows using a custom instance of Ajv with the extra formatters.
Allows passing custom ajv instance to the schema function. This might be the only change we really want. Then I can write some docs on how to customize AJV and provide it as the second function.


          feat(schema): allow custom ajv in schema function

2c7fe19

marshallswain force-pushed the schema-add-formats branch from 8db3f8c to 2c7fe19 Compare

December 22, 2021 20:05

marshallswain changed the title ~~feat(schema): add ajv-formats~~ feat(schema): test for using a custom AJV with ajv-formats

marshallswain requested a review from daffl

December 22, 2021 20:08

marshallswain and others added 3 commits

December 22, 2021 22:57


          test(schema): example convert strings to dates

bb76220


          test(schema): date conversion works with queryProperty

ae4726c


          Clean up package-lock.json

cb913c2

daffl merged commit ecfa4df into dove

daffl deleted the schema-add-formats branch

January 3, 2022 22:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet