Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(configuration): Only validate the initial configuration against the schema #2622

Merged
merged 1 commit into from
May 4, 2022
Merged

fix(configuration): Only validate the initial configuration against the schema #2622

merged 1 commit into from
May 4, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented May 3, 2022

This is still not ideal but at least ensures that the schema only runs against the initial configuration provided by node-config and not anything set via app.set before setup is called.

@daffl daffl merged commit 386c5e2 into dove May 4, 2022
@daffl daffl deleted the validate-config branch May 4, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daffl