Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Use proper MSSQL client #2853

Merged
merged 1 commit into from
Nov 5, 2022
Merged

fix(cli): Use proper MSSQL client #2853

merged 1 commit into from
Nov 5, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented Nov 5, 2022

Closes #2850

@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for feathers-dove canceled.

Name Link
🔨 Latest commit ef1d69e
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/6365e6883cdc0d0008f57f9d

@daffl daffl merged commit bae5176 into dove Nov 5, 2022
@daffl daffl deleted the cli-mssql branch November 5, 2022 04:44
@daffl daffl mentioned this pull request Nov 5, 2022
@jbridgenet
Copy link

Actually there are more issues with mssql migration.

After I changed the client name to mssql, I could run that script, but more errors when I run:
npm run migrate

  1. failed to parse server name when I put localhost\SQLEXPRESS, then
  2. failed to parseInt of port

After I manually hard coded it, it failed to login with my 'sa' account...

Please test again before release it

@daffl
Copy link
Member Author

daffl commented Nov 5, 2022

It will need the connection string that is being generated:

mssql://root:password@localhost:1433/${name}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mssql config issue
2 participants