fix(adapter-commons): multiple issues in adapter-commons #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 6732e2c |
fratzinger
reviewed
Nov 16, 2022
| @@ -51,7 +50,7 @@ export class MethodBase | |||
| } | |||
|
|
|||
| async $update(id: NullableId, _data: Data, _params?: AdapterParams) { | |||
There was a problem hiding this comment.
As far as I know, NullableId is wrong for update. Only patch and remove are allowed to have a NullableId. Am I wrong @daffl?
There was a problem hiding this comment.
Correct. It should just be Id. If the interface were setup for NullableId, it would mean you could completely replace multiple documents with the same id, which isn't possible.
There was a problem hiding this comment.
This was my bad. A bunch of those issues will be fixed in #2906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(If you have not already please refer to the contributing guideline as described
here)
If so, please mention them to keep the conversations linked together.
Other Information
This PR solves the following issues:
Partial<Partial<T>>never[]toany[]in service.test.ts of adapter-commons to prevent type errorFeedback
It is hard to find the contributing.md file. I suggest adding a link in the README.md for better visibility.