fix(mongodb): Added Update Method Prototype to MongoDBService Class #3485 #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the update method prototype to the MongoDBService class in index.ts. This allows the update method to be used with the correct typings. This is related to issue feathersjs#3485
daffl
changed the title
daffl
approved these changes
Jun 9, 2024
|
That makes sense, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds the update method prototype to the MongoDBService class in the
index.tsfile. This change allows the update method to be used with the correct typings, improving the type safety and developer experience when using the MongoDBService class.Changes:
index.tsThis pull request is related to issue #3485
Please review the changes and let me know if anything needs to be updated or improved.