Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Encoding #792

Open
NTUST-MITLAB opened this issue Oct 19, 2020 · 0 comments
Open

Character Encoding #792

NTUST-MITLAB opened this issue Oct 19, 2020 · 0 comments

Comments

@NTUST-MITLAB
Copy link

Ever since the patch for this #635, I've always had issues with random player names displayed on top, since it forced "WINDOWS-1252" encoding to "gb2312" which only works with Simplified Chinese, where a system with Traditional Chinese uses "Big5" (which is also WINDOWS-1252). In this case, when the information is changed, it would display with the wrong characters, even if it is saved and load by Lizzie itself.

I've applied a dirty fix myself ever since by adding an encoding method to the save function in the SGFParser.java with Writer writer = new OutputStreamWriter(new FileOutputStream(filename), "UTF-8") so I can manually change the info and write back as UTF-8 encoding, which would work well even with other platforms. But it is not a good fix by any measure.

I feel it is time to properly add the CA property tag for the encoding in the SGF format like most current sgf software already did (like Sabaki, MultiGo, GoGUI, etc.) to permanently solve the character encoding and display issue disregarding which platform it is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant