Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: Support click the node in the variation #414

Merged
merged 2 commits into from
Nov 8, 2018
Merged

next: Support click the node in the variation #414

merged 2 commits into from
Nov 8, 2018

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Oct 31, 2018

Base on #412 #413
Closes #391

Support click the node in the variation

@featurecat
Copy link
Owner

The travis build failed -- could you take a look?

@zsalch
Copy link
Contributor Author

zsalch commented Nov 8, 2018

I will solve it.

@zsalch zsalch closed this Nov 8, 2018
@zsalch zsalch reopened this Nov 8, 2018
@zsalch
Copy link
Contributor Author

zsalch commented Nov 8, 2018 •
edited
Loading

I committed again, but the travis check seems auto cancelled.

This job was cancelled because the "Auto Cancellation" feature is currently enabled, and a more recent build (#28) for pull request #414 came in while this job was waiting to be processed.

@featurecat
Copy link
Owner

Oh interesting. I'm not sure if I like that feature or not. Restarted the build.

@featurecat featurecat merged commit 5525215 into featurecat:next Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBlanvillain OlivierBlanvillain Awaiting requested review from OlivierBlanvillain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsalch @featurecat