Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuSpec issues #199

Closed
Hawxy opened this issue Dec 12, 2018 · 4 comments
Closed

NuSpec issues #199

Hawxy opened this issue Dec 12, 2018 · 4 comments
Labels

Comments

@Hawxy
Copy link
Contributor

Hawxy commented Dec 12, 2018

Thanks for the v3.0.0-rc release, but there's a problem

I'm not why you added a nuspec when the csproj's were already updated with nuget information (which generate nuget packages whenever dotnet pack or a publish is run). nuspecs are considered outdated compared to csproj definitions and really shouldn't be used anymore outside of complex use-cases.

NETStandard.Library is also not a required dependency and can be removed

@obstar
Copy link
Collaborator

obstar commented Dec 12, 2018

ok, I will switch to that when releasing proper ''latest release' of 3.0.1

@obstar
Copy link
Collaborator

obstar commented Dec 12, 2018

@Hawxy the only issue I've got with csproj instead of nuspec is this one:

so the nuget package for Coypu.NUnit that came from csproj is:

<group targetFramework=".NETFramework4.5">
        <dependency id="Coypu" version="3.0.1" exclude="Build,Analyzers" />
        <dependency id="NUnit" version="[3.11.0, 4.0.0)" exclude="Build,Analyzers" />
      </group>
 <group targetFramework=".NETStandard2.0">
        <dependency id="Coypu" version="3.0.1" exclude="Build,Analyzers" />
        <dependency id="NUnit" version="[3.11.0, 4.0.0)" exclude="Build,Analyzers" />
 </group>

from nuspec

 <group targetFramework=".NETFramework4.5">
        <dependency id="Coypu" version="[3.0.1, 4.0.0)" />
        <dependency id="NUnit" version="[3.11.0, 4.0.0)" />
</group>
<group targetFramework=".NETStandard2.0">
        <dependency id="Coypu" version="[3.0.1, 4.0.0)" />
        <dependency id="NUnit" version="[3.11.0, 4.0.0)" />
 </group>

I guess I can manually modify those version range for Coypu dependency in Coypu.NUnit package..

[edit]
ok I think I will create package from csproj and modify manually version range for coypu dependency in Coypu.NUnit package so I can also remove nuspec related stuff

@obstar
Copy link
Collaborator

obstar commented Dec 12, 2018

I've also tested release candidate build and all works well on my end so soon I will release official stable build

@obstar
Copy link
Collaborator

obstar commented Dec 13, 2018

@Hawxy new release https://github.com/featurist/coypu/releases/tag/3.0.1
ok compromise is that coypu is created from csproj and coypu.nunit from nuspec when they fix the issue with version range for project references I will be able to switch fully to csproj for coypu.nunit

@obstar obstar closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants