Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Form and Schedule Schemas to match updated specification templates #1539

Closed
1 of 5 tasks
GreggMoreland opened this issue Nov 20, 2023 · 8 comments
Closed
1 of 5 tasks
Assignees

Comments

@GreggMoreland
Copy link

GreggMoreland commented Nov 20, 2023

Business Reason

Task 1: Update the Form 3X schema to match the current updated specification standards, using the specification in this document

Task 2: Verify the Form 1M schema matches the current updated specification standards, using the specification in this document (Differences highlighed in yellow)

  • All Form 1M changes are complete

Task 3: Verify the Form 24 schema matches the current updated specification standards, using the specification in this document (Differences highlighed in yellow)

  • All Form 24 changes are complete

Task 4: Verify the Form 99 schema to matches the current updated specification standards, using the specification in this document (Differences highlighed in yellow)

  • All Form 99 changes are complete

QA Notes

  • BA/Design Quality Checklist complete
  • BA's will verify ticket

DEV Notes

Design

null

FECFILE-548

@AureliaKhorsand
Copy link
Contributor

Thanks @GreggMoreland , let's talk through this at our next sync-up

@WiseQA
Copy link

WiseQA commented Jun 3, 2024

No QA review for this tickets as noted in AC BA's verified ticket before moving to QA bucket.

Ticket moved to Stage Ready.

@AureliaKhorsand
Copy link
Contributor

@sasha-dresden and @GreggMoreland - has this actually been reviewed? I'm looking at the schemas and they don't seem to be updated. I might be totally missing something, but they should be matching what is in the linked documents.

@AureliaKhorsand
Copy link
Contributor

@mjtravers and I chatted, and the schedule updates no longer apply based on how we use (or rather, don't use) the schedule schemas. The schedule schemas match the vendorpak, but we validate against transaction and form schemas. Updated ticket to clarify that it's just the Form ones that need updating. @sasha-dresden @GreggMoreland

@GreggMoreland
Copy link
Author

@sasha-dresden @mjtravers Here are the things I have found:

  • In C1, it has 'X (warerrorning)' in the validation for Lender State. It should be 'X (error)'
  • In C2, GUARANTEED AMOUNT has the 'X (error)' in the Rule Reference column but it should be in the Required column

@mjtravers
Copy link
Contributor

@GreggMoreland The C1 and C2 specs have had the 2 issues listed above corrected:

https://fecgov.github.io/fecfile-validate/SchC1_spec.html
https://fecgov.github.io/fecfile-validate/SchC2_spec.html

@GreggMoreland
Copy link
Author

@mjtravers @sasha-dresden @AureliaKhorsand It looks good to me now.

Copy link

Aurelia Khorsand commented: Sprint accepted 6/18/2024 during Sprint Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants