Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Angular to v17 #1887

Closed
mjtravers opened this issue Apr 27, 2024 · 5 comments
Closed

Upgrade Angular to v17 #1887

mjtravers opened this issue Apr 27, 2024 · 5 comments
Assignees

Comments

@mjtravers
Copy link
Contributor

mjtravers commented Apr 27, 2024

Upgrade front-end to Angular v17 from our current Angular 16.

Angular does a major release every 6 months: https://angular.io/guide/releases#release-frequency

Here are the breaking changes: https://angular.io/guide/update-to-version-17#highlighted-breaking-changes-in-angular-v17

Steps to upgrade: https://update.angular.io/?l=3&v=16.0-17.0

QA Notes

Ticket passes if unit tests and e2e tests pass.

      1. QA Notes ###

           Angular does a major release every 6 months: [https://angular.io/guide/releases#release-frequency](https://angular.io/guide/releases#release-frequency)
        

Here are the breaking changes: https://angular.io/guide/update-to-version-17#highlighted-breaking-changes-in-angular-v17

Steps to upgrade: https://update.angular.io/?l=3&v=16.0-17.0

QA Notes

Ticket passes if unit tests and e2e tests pass.

      1. DEV Notes ###

           null
        
      2. Design ###

           null
        

QA Notes

Angular does a major release every 6 months: https://angular.io/guide/releases#release-frequency

Here are the breaking changes: https://angular.io/guide/update-to-version-17#highlighted-breaking-changes-in-angular-v17

Steps to upgrade: https://update.angular.io/?l=3&v=16.0-17.0

QA Notes
Ticket passes if unit tests and e2e tests pass.

DEV Notes

null

Design

null

FECFILE-415

@mjtravers
Copy link
Contributor Author

@Elaine-Krauss-TCG I'm getting one e2e test failure when running locally in the reports-f3x-amendments tests:

Image

Sending back to In Progress to investigate test failure.

@Elaine-Krauss-TCG
Copy link
Contributor

All E2E tests are passing for me, locally. Would you be able to get me screenshots or the automatically recorded video?

Image

Image

@WiseQA WiseQA self-assigned this May 20, 2024
@WiseQA WiseQA added the on hold label May 20, 2024
@WiseQA
Copy link

WiseQA commented May 20, 2024

@mjtravers @MitchellTCG @Elaine-Krauss-TCG @sasha-dresden please add passing current unit tests and validation screenshot Angular was upgraded to v17 for validation of this fix. Thanks

@sasha-dresden
Copy link
Contributor

Passing unit tests
Image

Package details. Note the ones marked @angular are set to 17
Image

@WiseQA WiseQA removed the on hold label May 20, 2024
@WiseQA
Copy link

WiseQA commented May 20, 2024

Per DEV QA verified Unit Tests passing for this ticket.

QA verified with DEV Angular version upgraded.

Moved to Stage Ready.

@WiseQA WiseQA removed their assignment May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants