Update e2e tests and deploy strategy

[lbeaufort]

Business Reason

As a developer, I will be able to deploy to production even if end-to-end tests are failing so that I can quickly address time-sensitive production issues.

After this is deployed to develop:

• turn off nightly e2e-test job in circleci environment
• run e2e tests when app repo merges into develop branch
• run e2e tests when api repo merges into develop, release, or main branches
• proceed with deploy on PROD for both app and api repos when any required jobs including e2e-test fails

QA Notes

null

DEV Notes

It might make the most sense to fail develop and release branches, but not production. Relevant issue: #1928

The CircleCI config.yml file needs to be updated here to not had a requires deploy dependency on e2e-tests:

Design

null

See full ticket and images here: FECFILE-393

[mjtravers]

Blocked by #2009
Placing ticket on hold.

[mjtravers]

During testing, it was found that for target deployments that do not require e2e tests to pass, that the deployment was no longer failing for unit tests, linting, and dependency check. Sending ticket back to In Progress.

See screenshot of CircleCI dashboard:

[mjtravers]

#2009 no longer blocking this ticket. Removing "on hold" tag.

[mjtravers]

Here are the settings of the CircleCI "e2e tests nightly" trigger should we need to restore it at some point in the future:

Complete form:

Bottom section of form:

[mjtravers]

Passes CR. Sending to QA.

Here is screenshot showing deploy to DEV dependency on successful e2e tests:

[exalate-issue-sync]

Shelly Wise commented: QA review verified as a visual inspection per DEV successfully showing deploy to DEV dependency on successful e2e tests. (See DEV CR links below)

QA Review Completed. Moved to Stage Ready.

[exalate-issue-sync]

Matt Travers commented: Noticed that when triggering the e2e tests from the fecfile-web-api repo, that a deployment is made of the fecfile-web-app develop branch unnecessarily.

Here’s a screenshot of the double running of the fecfile-web-app CircleCI jobs. Only the triggered-e2e-test job should run:

!image-20240710-164107.png|width=864,height=224,alt="image-20240710-164107.png"!

Moving ticket back to In Progress.

[exalate-issue-sync]

Matt Travers commented: Updated original commit to ensure deployment failed to STAGE and PROD if linting, unit tests, or dependency check failed.
Also updated logic so that fecfile-web-app does not deploy when e2e tests triggered from fecfile-web-api.

[exalate-issue-sync]

Matt Travers commented: For QA:

Here is a screenshot of the fecfile-web-api commit triggering the e2e test in fecfile-web-app without setting off a deploy to fecfile-web-app:

!image-20240718-202124.png|width=1268,height=480,alt="image-20240718-202124.png"!

[exalate-issue-sync]

Matt Travers commented: Passes CR. Sending to QA.

[exalate-issue-sync]

Shelly Wise commented: QA review verified with DEV the fecfile-web-api commit triggering the e2e test in fecfile-web-app without setting off a deploy to fecfile-web-app:

!image-20240722-151634.png|width=921,height=360,alt="image-20240722-151634.png"!

e2e tests showing success below:

!image-20240722-151518.png|width=1583,height=414,alt="image-20240722-151518.png"!

QA Review Completed. Moved to Stage Ready.

[exalate-issue-sync]

akhorsand commented: Accepted by Paul Clark at 7/30/24 sprint review.