-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility function to read samples from a file #15
Comments
You're right, this was a very ugly hack just for the review. However, in C++ it's very easy to read numbers from a file using
and then in
I didn't put too much effort in that example, because the user is required to implement the class |
What I was thinking is that instead of modifying the example, to overload add_sample() in order to get a filename as an argument, since this might be a frequently used feature. |
I agree, it's fine for me. |
In the simple_hello_world_cv_2.cpp example the time samples are provided statically in an array defined in the test_cv_values.h header file. However, this means that the program has to be recompiled every time in order to be used with a new data set.
In order chronovise to be easier to use by end-users (e.g. engineers not developers) , it would be useful to provide a utility function that can parse directly an input file such as test_cv_values.txt. Moreover, this will provide compatibility with MBPTA-CV.
The text was updated successfully, but these errors were encountered: