Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Notifications #1

Open
timqian opened this issue Apr 30, 2020 · 0 comments
Open

Enable Notifications #1

timqian opened this issue Apr 30, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@timqian
Copy link
Member

timqian commented Apr 30, 2020

The extension only shows unread count on the badge.

People might also want to get a notification for unread content.

It can be helpful to add an option for users to receive notifications of unread content.

[Possible way to implement]

  • add a notification toggle in src/options.html and save the toggle to localstorge
  • in src/utils/queries.js when querying GET_USER_UNREAD, query not only summaries but also contents.
  • in src/background.jscheck unread contents and notify user if necessary
    1. query unread contents
    2. check if user turned on notifications, if turned on, send user notifications and save notification time(used to decide if a notification is already sent in the next check)

Ref

  • sample code to send notifications: b002e8c
@timqian timqian added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant