From 3dd45dde7b92531b2530ab54522bb843c56227a7 Mon Sep 17 00:00:00 2001
From: AlbertoEAF <AlbertoEAF@users.noreply.github.com>
Date: Sun, 18 Oct 2020 11:07:02 +0100
Subject: [PATCH] Add PRIVATE argument to target_link_libraries

---
 CMakeLists.txt | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 57d5e1a3f72c..10e7fb0749cc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -386,20 +386,20 @@ if(USE_SWIG)
 endif(USE_SWIG)
 
 if(USE_MPI)
-  TARGET_LINK_LIBRARIES(lightgbm ${MPI_CXX_LIBRARIES})
-  TARGET_LINK_LIBRARIES(_lightgbm ${MPI_CXX_LIBRARIES})
+  TARGET_LINK_LIBRARIES(lightgbm PRIVATE ${MPI_CXX_LIBRARIES})
+  TARGET_LINK_LIBRARIES(_lightgbm PRIVATE ${MPI_CXX_LIBRARIES})
 endif(USE_MPI)
 
 if(USE_OPENMP)
     if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
-        TARGET_LINK_LIBRARIES(lightgbm OpenMP::OpenMP_CXX)
-        TARGET_LINK_LIBRARIES(_lightgbm OpenMP::OpenMP_CXX)
+        TARGET_LINK_LIBRARIES(lightgbm PRIVATE OpenMP::OpenMP_CXX)
+        TARGET_LINK_LIBRARIES(_lightgbm PRIVATE OpenMP::OpenMP_CXX)
     endif()
 endif(USE_OPENMP)
 
 if(USE_GPU)
-  TARGET_LINK_LIBRARIES(lightgbm ${OpenCL_LIBRARY} ${Boost_LIBRARIES})
-  TARGET_LINK_LIBRARIES(_lightgbm ${OpenCL_LIBRARY} ${Boost_LIBRARIES})
+  TARGET_LINK_LIBRARIES(lightgbm PRIVATE ${OpenCL_LIBRARY} ${Boost_LIBRARIES})
+  TARGET_LINK_LIBRARIES(_lightgbm PRIVATE ${OpenCL_LIBRARY} ${Boost_LIBRARIES})
 endif(USE_GPU)
 
 if(__INTEGRATE_OPENCL)
@@ -419,34 +419,36 @@ if(USE_CUDA)
   set_target_properties(lightgbm PROPERTIES CUDA_RESOLVE_DEVICE_SYMBOLS ON)
   TARGET_LINK_LIBRARIES(
     lightgbm
+    PRIVATE
     ${histograms}
   )
   set_target_properties(_lightgbm PROPERTIES CUDA_RESOLVE_DEVICE_SYMBOLS ON)
   TARGET_LINK_LIBRARIES(
     _lightgbm
+    PRIVATE
     ${histograms}
   )
 endif(USE_CUDA)
 
 if(USE_HDFS)
-  TARGET_LINK_LIBRARIES(lightgbm ${HDFS_CXX_LIBRARIES})
-  TARGET_LINK_LIBRARIES(_lightgbm ${HDFS_CXX_LIBRARIES})
+  TARGET_LINK_LIBRARIES(lightgbm PRIVATE ${HDFS_CXX_LIBRARIES})
+  TARGET_LINK_LIBRARIES(_lightgbm PRIVATE ${HDFS_CXX_LIBRARIES})
 endif(USE_HDFS)
 
 if(WIN32)
     if(MINGW OR CYGWIN)
-      TARGET_LINK_LIBRARIES(lightgbm Ws2_32)
-      TARGET_LINK_LIBRARIES(_lightgbm Ws2_32)
-      TARGET_LINK_LIBRARIES(lightgbm IPHLPAPI)
-      TARGET_LINK_LIBRARIES(_lightgbm IPHLPAPI)
+      TARGET_LINK_LIBRARIES(lightgbm PRIVATE Ws2_32)
+      TARGET_LINK_LIBRARIES(_lightgbm PRIVATE Ws2_32)
+      TARGET_LINK_LIBRARIES(lightgbm PRIVATE IPHLPAPI)
+      TARGET_LINK_LIBRARIES(_lightgbm PRIVATE IPHLPAPI)
     endif(MINGW OR CYGWIN)
 endif(WIN32)
 
 if(__BUILD_FOR_R)
   if(MSVC)
-    TARGET_LINK_LIBRARIES(_lightgbm ${LIBR_MSVC_CORE_LIBRARY})
+    TARGET_LINK_LIBRARIES(_lightgbm PRIVATE ${LIBR_MSVC_CORE_LIBRARY})
   else()
-    TARGET_LINK_LIBRARIES(_lightgbm ${LIBR_CORE_LIBRARY})
+    TARGET_LINK_LIBRARIES(_lightgbm PRIVATE ${LIBR_CORE_LIBRARY})
   endif(MSVC)
 endif(__BUILD_FOR_R)