Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError for minStack property #51

Closed
dlancer opened this issue Oct 7, 2018 · 1 comment
Closed

TypeError for minStack property #51

dlancer opened this issue Oct 7, 2018 · 1 comment

Comments

@dlancer
Copy link
Contributor

dlancer commented Oct 7, 2018

Master branch have a bug with TypeError for minStack property (strict mode web-build).
@dlancer dlancer mentioned this issue Oct 7, 2018
Merged
@felipemanga
Copy link
Owner

felipemanga commented Oct 8, 2018 •
edited
Loading

I've been testing this as a fix:
set minStack(value) {},

I haven't pushed it to master since I've made other fixes and I want to make sure it's stable first.

the setter gets called when copying properties from an old instance of the core to a new one.
The problem is that the minStack should be read-only and not get copied. That's why there wasn't a setter before.

Thanks for reporting the issue and for sending the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlancer @felipemanga