Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove VM-Dependency #1043

Open
TimeForANinja opened this issue Dec 16, 2021 · 4 comments
Open

remove VM-Dependency #1043

TimeForANinja opened this issue Dec 16, 2021 · 4 comments
Labels
dependencies Pull requests that update a dependency file feature

Comments

@TimeForANinja
Copy link
Collaborator

Replace the VM-Dependency added in #1022 by switching to a Script like descriped in #1022 (comment)

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that were closed for inactivity label Apr 16, 2022
@stale stale bot closed this as completed Apr 25, 2022
@TimeForANinja TimeForANinja reopened this Apr 30, 2022
@stale stale bot removed the stale Issues that were closed for inactivity label Apr 30, 2022
@fullerlee
Copy link

fullerlee commented May 12, 2022

I'm keeping an eye on this one. I'm successfully using ytdl-core in reactnative by patching a few of the dependencies as shown here: https://github.com/fullerlee/react-native-ytdl

However, I've encountered the throttled downloads. Merging in the new sig.js results in a new dependency of vm, and I've not been able to sensibly patch that one.

If anyone has any ideas on how I might patch it, or replace the dynamic script creation, I'd be most grateful!

@TimeForANinja
Copy link
Collaborator Author

i mean it should be enough to replace new vm.Script(xxx) in sig.js with an eval(xxx) call

@fullerlee
Copy link

i mean it should be enough to replace new vm.Script(xxx) in sig.js with an eval(xxx) call

That's exactly what I've done to make it react-native compatible. Albeit by patching vm-browserify. It's a work-in-progress, but see https://github.com/fullerlee/react-native-ytdl/blob/master/lib/__REACT_NATIVE_YTDL_CUSTOM_MODULES__/vm/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature
Projects
None yet
Development

No branches or pull requests

2 participants