Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin apps are no longer allowed to set host headers with Wasmtime 21.0.1 #2575

Closed
Tracked by #2570
mikkelhegn opened this issue Jun 18, 2024 · 6 comments
Closed
Tracked by #2570
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@mikkelhegn
Copy link
Member

Using the Canary version of Spin, a guest (Spin component), is no longer able to set the host header on outbound http requests.

This change in Wasmtime is what impacts this: bytecodealliance/wasmtime#7905. It was incorporated in Spin with Wasmtime 21.0.1 #2538.

Currently looking in to a potential update to Wasmtime to relax and still allow host headers to be set from the guest.

@mikkelhegn mikkelhegn added the bug Something isn't working label Jun 18, 2024
@mikkelhegn mikkelhegn changed the title Spin apps are no longer allowed to set host headers with Wasmtiem 21.0.1 Spin apps are no longer allowed to set host headers with Wasmtime 21.0.1 Jun 18, 2024
@mikkelhegn mikkelhegn mentioned this issue Jun 18, 2024
6 tasks
@lann
Copy link
Collaborator

lann commented Jun 18, 2024

There aren't many reasons to set a host header manually so I'm inclined to wait for someone to bring this up as an actual issue before suggesting an upstream change.

@mikkelhegn
Copy link
Member Author

@karthik2804 - I know you noticed this working on the new JS SDK. Can you please bring up here what the scenario where this was encountered is?

@karthik2804
Copy link
Contributor

I was working on getting the s3 client to work and ran into issues because StarlingMonkey was originally setting the host header and it caused duplicate headers and when I tried running against canary, I got an error about failed to clone headers which was due to the failure to create the resource but that has now been fixed in StarlinMonkey.

@lann
Copy link
Collaborator

lann commented Jun 18, 2024

StarlingMonkey was originally setting the host header

To be clear: this was not released code?

@karthik2804
Copy link
Contributor

@lann no it is not released code, I have been building of a PR branch.

@mikkelhegn
Copy link
Member Author

Thx for the clarifications. I will close this issue as will-not-fix.

@mikkelhegn mikkelhegn added the wontfix This will not be worked on label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants