Fix createURL #1971
Merged
Fix createURL #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Javascript URL object takes a second argument which is the base to use for the URL. However it only accepts the "root" of the base. So arguments such as http://localhost/example get silently turned into http://localhost/ This change places the baseURL within the path element, after making sure that it ends with a slash (/).
|
Fixes #1970 |
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Aug 29, 2022
(cherry picked from commit 1e7d3b2)
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Aug 29, 2022
(cherry picked from commit 1e7d3b2)
rahul-r
pushed a commit
to rahul-r/filebrowser
that referenced
this pull request
Sep 2, 2022
Shada
pushed a commit
to Shada/filebrowser
that referenced
this pull request
Feb 22, 2023
Shada
pushed a commit
to Shada/filebrowser
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javascript URL object takes a second argument which is the base to
use for the URL. However it only accepts the "root" of the base. So
arguments such as http://localhost/example get silently turned into
http://localhost/
This change places the baseURL within the path element, after making
sure that it ends with a slash (/).