Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deal/sector activation from cron #1277

Closed
Tracked by #1276
jennijuju opened this issue Apr 10, 2023 · 5 comments · Fixed by #1540
Closed
Tracked by #1276

Remove deal/sector activation from cron #1277

jennijuju opened this issue Apr 10, 2023 · 5 comments · Fixed by #1540
Assignees

Comments

@jennijuju
Copy link
Member

jennijuju commented Apr 10, 2023

  • Option A: Remove async proof validation - Drop ProveCommit and always use ProveAggregateSectors
  • Option B: Add an explicit activation step for all sectors that’s triggered by a message sent by SPS

A and B are mutually exclusive. If we do A, B less less useful in general. However, B is useful for SaaS/Inaactive CC sector providers.

@jennijuju jennijuju changed the title Safer cron for single prove commit Remove deal/sector activation from cron Apr 10, 2023
@anorth
Copy link
Member

anorth commented May 22, 2023

There is good discussion in filecoin-project/FIPs#689. I don't think the options are mutually exclusive.

For option A it is quite likely that using an aggregated proof wastes resources for proving a single sector, and we'll instead need a new method that uses non-aggregated proof but synchronously activates the sector.

Option B above is under-specified. I assume it doesn't mean changing the behaviour of the existing proof method across the board. It probably means some new methods that prove without activating. These can still be useful even with option A.

In any case the protocol design needs to be worked out in a draft FIP before we dive into code.

@jennijuju
Copy link
Member Author

For lotus/actor team - this will be a P3 & blocked until we have better understanding on projects like sector events/direct FIL+ given the design/scope/timeline dependencies.

@anorth
Copy link
Member

anorth commented Aug 22, 2023

Note if a new ProveCommitBatch is added, that proves synchronously but without the overheads of proof aggregation, it will depend on filecoin-project/ref-fvm#1852 for correct gas accounting.

@anorth
Copy link
Member

anorth commented Aug 23, 2023

The new ProveCommit2 in #1380 will synchronously validate proofs. So after that is live, we can eventually solve this by deprecating the original (will require parties to move to direct onboarding flow, though that can still support deals).

@mb1896 mb1896 self-assigned this Oct 9, 2023
@anorth
Copy link
Member

anorth commented Jan 22, 2024

This will be FIP-0084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants