Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument --to and --from not respected for historical tipset indexing #142

Closed
placer14 opened this issue Oct 26, 2020 · 3 comments · Fixed by #234
Closed

Argument --to and --from not respected for historical tipset indexing #142

placer14 opened this issue Oct 26, 2020 · 3 comments · Fixed by #234
Assignees
Labels
kind/enhancement Improvement to an existing feature P2 P2: Should be resolved

Comments

@placer14
Copy link
Contributor

placer14 commented Oct 26, 2020

Ran the following visor command intending to capture from 178800 and prior tipsets but found tipset past 178800 in the visor_processing_tipsets table.

Should apply to all indexing and processing except indexhead.

./visor --repo=/lotus-data/.lotus --db-pool-size=15 --log-level=info run --indexhead=false --to 178800 --scb 50 --scw 5 --asb 50 --asw 5 --mb 50 --mw 5 --gob 50 --gow 5 --ceb 50 --cew 5 --indexhistory=true

@placer14 placer14 added the kind/bug Kind: Bug label Oct 26, 2020
@iand
Copy link
Contributor

iand commented Oct 26, 2020

--to only applies to actor and message processing tasks: "Limit actor and message processing to tipsets at or below HEIGHT"

We could make the history indexer respect it for writing to the database. It probable would still have to start higher than the --to value and walk backwards unless there is a way to get the tipset for an epoch via the API

@iand iand added kind/enhancement Improvement to an existing feature and removed kind/bug Kind: Bug labels Oct 26, 2020
@placer14 placer14 added the P2 P2: Should be resolved label Oct 27, 2020
@placer14 placer14 changed the title Argument --to not respected for historical tipset indexing Argument --to and --from not respected for historical tipset indexing Oct 27, 2020
@frrist
Copy link
Member

frrist commented Oct 30, 2020

We could prevent the historical index from writing to the db if the to and from out outside its range.

@hsanjuan hsanjuan self-assigned this Nov 9, 2020
@frrist
Copy link
Member

frrist commented Nov 13, 2020

@iand has a fix for this in #221

@iand iand linked a pull request Nov 17, 2020 that will close this issue
@iand iand closed this as completed in #234 Nov 18, 2020
@hsanjuan hsanjuan assigned iand and unassigned hsanjuan Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement to an existing feature P2 P2: Should be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants