Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: Flatten migrations #225

Closed
3 tasks
placer14 opened this issue Nov 13, 2020 · 1 comment · Fixed by #528
Closed
3 tasks

schema: Flatten migrations #225

placer14 opened this issue Nov 13, 2020 · 1 comment · Fixed by #528
Labels
kind/chore Technical debt due to be resolved P2 P2: Should be resolved topic/documentation Topic: Documentation

Comments

@placer14
Copy link
Contributor

As a semi-regular maintenance task, we should occasionally flatten the migrations which are no longer needing support.

Acceptance Criteria

  • Create Base Schema which represents the execution of migrations 0->X (TODO: What is X? Recommend latest migration ver in v0.3.0.)
  • Make migrations 0->(X-1) error upon execution migrations and migration X should execute Base Schema creation.
  • Update migrations README with note on flattening pattern employed here and what this means for a user trying to migrate existing data through a release pre-v0.3.0 and beyond. (Mentioned in discussion.)

To Discuss

  • What version should we flatten migrations up to? X must necessarily be something within the prior release and earlier (aka can't be unrelease in master). This approach would require anyone who doesn't which to start fresh to upgrade to v0.3.0 before upgrading further.
@placer14 placer14 added kind/chore Technical debt due to be resolved topic/documentation Topic: Documentation labels Nov 13, 2020
@placer14 placer14 mentioned this issue Nov 13, 2020
Closed
@frrist frrist mentioned this issue Nov 19, 2020
Merged
@frrist frrist added the P2 P2: Should be resolved label Dec 2, 2020
@iand
Copy link
Contributor

iand commented Jan 15, 2021

Maybe this can be subsumed by #360

@iand iand mentioned this issue May 27, 2021
Merged
@iand iand closed this as completed in #528 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/chore Technical debt due to be resolved P2 P2: Should be resolved topic/documentation Topic: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add v1 schema filecoin-project/lily
3 participants
@iand @placer14 @frrist