Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Miner Deadlines #61

Closed
3 tasks
placer14 opened this issue Oct 5, 2020 · 3 comments
Closed
3 tasks

Capture Miner Deadlines #61

placer14 opened this issue Oct 5, 2020 · 3 comments
Assignees
Labels
kind/feature New feature request P1 P1: Must be resolved

Comments

@placer14
Copy link
Contributor

placer14 commented Oct 5, 2020

In order to understand WindowPoSt commitments and how they are being maintained on-chain, we will extract StorageMinerActor.Deadlines and its related data into Sentinel schema for monitoring and analysis.

Requirements:

  1. Produced schema should express ability to query for
    a. PoSts expected (per miner, per sector, per deadline CID (unsure how to uniquely identify deadlines))
    b. Messages (as well as other mechanisms required by Miner to fulfill successful PoSt) which satisfy expected PoSts

Deliverables:

  • Migration which relates the following objects Miners --hasmany-> Deadlines --hasmany-> Partitions --hasmany-> Sectors
  • StorageMinerActor extractors which support the schema produced in the previous migration
  • Example query (or pseudoquery) expressing ability to achieve R1 (a and b)
@placer14 placer14 added the kind/enhancement Improvement to an existing feature label Oct 5, 2020
@frrist
Copy link
Member

frrist commented Oct 22, 2020

@willscott did #74 resolve this? If not, what is left to do here?

@frrist frrist added kind/feature New feature request and removed kind/enhancement Improvement to an existing feature labels Oct 22, 2020
@frrist frrist added the P1 P1: Must be resolved label Oct 30, 2020
@frrist
Copy link
Member

frrist commented Oct 30, 2020

#74 gives us the times there was a successful window post, however it does not capture when their is a cron event that misses a deadline. We think the work that remains here involves capturing the cron event case, @willscott can you add anything missed in this description.

@willscott
Copy link
Contributor

that's correct:

  • the current table is populated when relevant miner state changes across tipsets. this is the correct and sufficient trigger.
  • When this happens, we find all relevant messages, and populate message, miner, and affected sectors.
  • Miner changes may also be unrelated to messages, and be due to cron-based expiry of post windows. we initially planned to populate these with an empty message ID. It is somewhat unclear to me how valuable that additional signal is.

is the p1 adding this additional set of rows, or having a generated table and seeing if it's good enough for windowPoSt analysis?

@frrist frrist closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

3 participants