Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Message Pool validations #2650

Closed
schomatis opened this issue Jul 29, 2020 · 1 comment
Closed

Review Message Pool validations #2650

schomatis opened this issue Jul 29, 2020 · 1 comment
Assignees

Comments

@schomatis
Copy link
Contributor

In contrast with incoming blocks that we try to incorporate into the chain and update its state we do lightweight validations on incoming messages (we don't project the state into the future estimating how one message might conflict with another one). As a result we are very permissive right now on what we accept increasing the pool size more than we'd ideally want. Proper validation though is expensive and we need to define exactly which trade-offs are we willing to accept.

@schomatis schomatis self-assigned this Jul 29, 2020
@schomatis
Copy link
Contributor Author

Partly addressed in #3313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant