Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxSealingSectrosForDeals is set to 0 upon miner restart #4833

Closed
jennijuju opened this issue Nov 12, 2020 · 5 comments · Fixed by #4879
Closed

MaxSealingSectrosForDeals is set to 0 upon miner restart #4833

jennijuju opened this issue Nov 12, 2020 · 5 comments · Fixed by #4879
Assignees
Labels

Comments

@jennijuju
Copy link
Member

The title says it all😅

@arajasek
Copy link
Contributor

What problem does this fix (what's the current impact)? And why do we want it in 1.2.0?

@jennijuju
Copy link
Member Author

What problem does this fix (what's the current impact)? And why do we want it in 1.2.0?

This affects miners' config so we'd like to get it fixed sooner than later

@arajasek
Copy link
Contributor

I'd rather keep this milestone to mandatory issues only (if it doesn't get into 1.2.0, it has to wait until the next network upgrade).

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Nov 16, 2020

@arajasek the impact is:

  • people have no idea what config is running in their miner
  • the miner does not apply the config value anymore --> no sectors can enter WaitDeal state

is is not a restart issue. it gets set to 0 when setting the deal delay. as said in #4867 it affects might other values too - i am quite sure about the [Fees] section

[edit] i have to walk the second one back, kind of, got a sector in wait deal stage now. no idea why - the config says 0 - it waited at least 8h before appearing and has deals in it that are possibly hours to days old. it's confusing - a fix would be nice

@jennijuju
Copy link
Member Author

@PatrickDeuse please see #4879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants