Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose data transfer progress in the list-deals view for clients #5121

Closed
dineshshenoy opened this issue Dec 4, 2020 · 6 comments · Fixed by #5553
Closed

Expose data transfer progress in the list-deals view for clients #5121

dineshshenoy opened this issue Dec 4, 2020 · 6 comments · Fixed by #5553
Assignees
@dirkmc
Labels
area/ux Area: UX P2 P2: Should be resolved

Comments

@dineshshenoy
Copy link

It's helpful when monitoring deals to know much of the data transfer block has completed. We have this information on the client side but are not exposing it in the UX.

Suggestion: Append a percentage when doing a deal transfer.

Deal Transfer [56%]
@dineshshenoy dineshshenoy added P3 P3: Might get resolved area/ux Area: UX labels Dec 4, 2020
@dineshshenoy dineshshenoy added this to the 💹Storage Deal Success milestone Dec 4, 2020
@NSC-FIL
Copy link

NSC-FIL commented Dec 4, 2020

This would be nice for the miners to see as well.

@dirkmc
Copy link
Contributor

dirkmc commented Dec 7, 2020

Should we show the percentage in list-deals or in list-transfers?

@NSC-FIL
Copy link

NSC-FIL commented Dec 7, 2020

Can it be in both? It's good for miners to know which are verified client deals to prioritize them if needed.

@dineshshenoy
Copy link
Author

make it easier to cross-reference deals with transfers.

  • add the transfer ID to list-deals
  • add the deal ID to list-transfers
    Prefer both - List transfers is used more for debugging.

Also add percentage in list-deals UX.

@dirkmc
Copy link
Contributor

dirkmc commented Dec 8, 2020

Outputting the transferred percentage is blocked by ipfs/go-graphsync#126

@dineshshenoy dineshshenoy added P2 P2: Should be resolved and removed P3 P3: Might get resolved labels Jan 5, 2021
@dineshshenoy
Copy link
Author

Related to #5133

@dirkmc dirkmc mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirkmc dirkmc

Labels
area/ux Area: UX P2 P2: Should be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

show data transfer % for storage deals filecoin-project/lotus
3 participants
@dirkmc @dineshshenoy @NSC-FIL