Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup current deal ID in OnDealExpiredOrSlashed #5414

Closed
dirkmc opened this issue Jan 25, 2021 · 0 comments · Fixed by #5431
Closed

Lookup current deal ID in OnDealExpiredOrSlashed #5414

dirkmc opened this issue Jan 25, 2021 · 0 comments · Fixed by #5431
Assignees
@dirkmc
Labels
area/markets/client area/markets/storage P2 P2: Should be resolved team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Milestone
v1.11.3

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Jan 25, 2021 •
edited
Loading

OnDealExpiredOrSlashed takes a deal ID parameter.
However the deal ID may change if there's a reorg after the deal was published. In that case OnDealExpiredOrSlashed will error out.

Instead OnDealExpiredOrSlashed should take a deal proposal parameter and fetch the current deal ID, similarly to how OnDealSectorCommitted works.
@dineshshenoy dineshshenoy added this to the 💹Storage Deal Success milestone Jan 25, 2021
@dirkmc dirkmc mentioned this issue Jan 26, 2021
Merged
@raulk raulk added the team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs label Feb 23, 2021
@raulk raulk modified the milestones: 🤝 Deal Success, v1.11.3 Aug 18, 2021
@raulk raulk added the P2 P2: Should be resolved label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirkmc dirkmc

Labels
area/markets/client area/markets/storage P2 P2: Should be resolved team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Milestone
v1.11.3
Development

Successfully merging a pull request may close this issue.

markets: OnDealExpiredOrSlashed - get deal by proposal instead of deal ID filecoin-project/lotus
4 participants
@dirkmc @raulk @dineshshenoy @jennijuju