Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the default deal start epoch delay #6277

Closed
jennijuju opened this issue May 18, 2021 · 0 comments
Closed

Extend the default deal start epoch delay #6277

jennijuju opened this issue May 18, 2021 · 0 comments
Assignees
Labels
kind/enhancement Kind: Enhancement P1 P1: Must be resolved

Comments

@jennijuju
Copy link
Member

With MaxProveCommitDuration got extended 1 day -> 6 days in actor v5
https://github.com/filecoin-project/specs-actors/blob/a389ccae8d5df456ee6b93f3fc836717b0a7c8d9/actors/builtin/miner/policy.go#L176

We may presume miners may wait longer before submiiting a provecommit message to aggreate as many as many proofs as possible, therefore, lotus should extend the default deal start epoch delay to reduce the chances of deal getting expired by the time provecommitment lands on chain.

Suggested value to be 8 days (publishstoragedeal -> seal duration + pre commit + MaxProveCommitDuration + 8 hour buffer)

@jennijuju jennijuju added the kind/enhancement Kind: Enhancement label May 18, 2021
@jennijuju jennijuju added this to the Network Hyperdrive milestone May 18, 2021
@BigLep BigLep added the P1 P1: Must be resolved label May 18, 2021
@magik6k magik6k closed this as completed May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: Enhancement P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

4 participants