Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS: Add snapshot hash to checkpoints #12

Merged
merged 7 commits into from
Apr 26, 2022

Conversation

sergefdrv
Copy link
Contributor

@sergefdrv sergefdrv commented Apr 20, 2022

Relates to #9

Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd have written it the same way.

@sergefdrv
Copy link
Contributor Author

Summary of changes: added comments

@matejpavlovic matejpavlovic marked this pull request as ready for review April 22, 2022 15:57
@matejpavlovic matejpavlovic marked this pull request as draft April 22, 2022 16:17
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

pkg/iss/checkpoint.go Outdated Show resolved Hide resolved
@sergefdrv
Copy link
Contributor Author

Summary of changes: rebase with conflict resolution

@sergefdrv
Copy link
Contributor Author

Summary of changes: added diagnostic output on mismatching app snapshot hash

Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@matejpavlovic matejpavlovic merged commit bde1e63 into consensus-shipyard:main Apr 26, 2022
@sergefdrv sergefdrv deleted the checkpoint-hash branch April 26, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants