Implement MockPassiveModule #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike a simple mock object that could be generated by gomock for the PassiveModule interface, MockPassiveModule allows setting expectations on events and not on calls to ApplyEvents. part of consensus-shipyard#138
xosmig
force-pushed
the
mock-passive-module
branch
from
70d6cf9
to
61a92b1
Compare
|
Sorry I won't be able to review this for a week, feel free to merge without my review. And watch out for "Partly resolves #138", as GitHub doesn't care about "partly", AFAIK. If you merge this, the issue probably will be automatically closed. |
sergefdrv
reviewed
Jul 18, 2022
sergefdrv
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike a simple mock object that could be generated by gomock for
the PassiveModule interface, MockPassiveModule allows setting
expectations on events and not on calls to ApplyEvents.
part of #138