-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat app reconfiguration #180
Merged
matejpavlovic
merged 8 commits into
consensus-shipyard:main
from
matejpavlovic:chat-reconfig-rebased
Aug 12, 2022
Merged
Chat app reconfiguration #180
matejpavlovic
merged 8 commits into
consensus-shipyard:main
from
matejpavlovic:chat-reconfig-rebased
Aug 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Pavlovic <[email protected]>
WARNING! Stable checkpoint verification has been disabled because it is buggy. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
dnkolegov
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just several "don't forget" comments!
dnkolegov
reviewed
Aug 9, 2022
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
chat-reconfig-rebased
branch
from
August 12, 2022 12:39
76a4cd8
to
dd67812
Compare
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
chat-reconfig-rebased
branch
from
August 12, 2022 12:42
dd67812
to
7d5a063
Compare
matejpavlovic
changed the title
[WIP] Chat app reconfiguration
Chat app reconfiguration
Aug 12, 2022
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat app reconfiguration. This is still a WIP, as it breaks basically everything except the chat app.
It is, however, the first approach to reconfiguration (demonstrated on the chat app).
It will still be improved and the rest of the code will be adapted accordingly.