Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat app reconfiguration #180

Merged

Conversation

matejpavlovic
Copy link
Contributor

Chat app reconfiguration. This is still a WIP, as it breaks basically everything except the chat app.
It is, however, the first approach to reconfiguration (demonstrated on the chat app).
It will still be improved and the rest of the code will be adapted accordingly.

WARNING!
Stable checkpoint verification has been disabled because it is buggy.

Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
@matejpavlovic matejpavlovic marked this pull request as draft August 8, 2022 21:47
Copy link
Contributor

@dnkolegov dnkolegov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just several "don't forget" comments!

pkg/deploytest/fakeapp.go Outdated Show resolved Hide resolved
pkg/iss/checkpoint.go Outdated Show resolved Hide resolved
pkg/iss/checkpoint.go Outdated Show resolved Hide resolved
pkg/iss/config.go Outdated Show resolved Hide resolved
pkg/iss/leaderselectionpolicy.go Outdated Show resolved Hide resolved
samples/chat-demo/app.go Show resolved Hide resolved
samples/chat-demo/app.go Outdated Show resolved Hide resolved
samples/chat-demo/main.go Outdated Show resolved Hide resolved
@matejpavlovic matejpavlovic marked this pull request as ready for review August 12, 2022 12:48
@matejpavlovic matejpavlovic changed the title [WIP] Chat app reconfiguration Chat app reconfiguration Aug 12, 2022
@matejpavlovic matejpavlovic merged commit f89f005 into consensus-shipyard:main Aug 12, 2022
@matejpavlovic matejpavlovic deleted the chat-reconfig-rebased branch August 12, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants