Add hierarchical module IDs #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
force-pushed
the
structured-module-ids
branch
from
648968d
to
e3f6b3f
Compare
xosmig
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Thanks!
// It corresponds to a path in the module hierarchy.
In fact, it doesn't even have to be a path in the module hierarchy.
From the Mir core point of view, only the part of the module id until the first separator is used, the rest is just ignored by Mir.
It is up to the module implementations to decide what they do with the ignored part.
UPD: I am not asking you to change anything, just wanted to leave a note on this.
In preparation for submodules in Mir this commit introduces structured module IDs. They are backwards-compatible with the old unstructured ones, which are considered to be identifiers of top-level modules. Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
structured-module-ids
branch
from
e3f6b3f
to
f202c08
Compare
|
Thanks, good points, I still extended the comments, so the note doesn't get lost in an old pull request nobody looks at any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for submodules in Mir this commit introduces structured
module IDs. They are backwards-compatible with the old unstructured
ones, which are considered to be identifiers of top-level modules.