-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Availability module integration #192
Availability module integration #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Two points:
-
Maybe you should rename availability layer-specific events and methods in the chat app (e.g.
chat.ApplyDeliver
tochat.ApplyDeliverAvailabilityCertificate
) because it will not be obvious for a new user reading this for the first time -
Let's save the initial straightforward chat-app without any new Mir mechanisms (reconfig, multisig). Without it, there will be hard to see the Mir arsenal and evolution.
5901bbb
to
ace0efa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Matej Pavlovic <[email protected]>
A special logger useful for testing. Its log entries can later be checked against a reference. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
This is an intermediate commit, the system does not work in this state. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Nil certificates are produced by the PBFT view change for padding. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
The buffer size introduced in the params will be used later for buffering early messages. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
da18536
to
bb178ff
Compare
7cf7593
to
35f4f53
Compare
Signed-off-by: Matej Pavlovic <[email protected]>
35f4f53
to
2d14f3c
Compare
This branch uses the availability module instead of directly submitting requests to ISS.
The availability module still uses a static configuration though, so reconfiguration is not yet supported on this branch.