Availability module integration #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
changed the title
dnkolegov
reviewed
Aug 19, 2022
There was a problem hiding this comment.
LGTM!
Two points:
-
Maybe you should rename availability layer-specific events and methods in the chat app (e.g.
chat.ApplyDelivertochat.ApplyDeliverAvailabilityCertificate) because it will not be obvious for a new user reading this for the first time -
Let's save the initial straightforward chat-app without any new Mir mechanisms (reconfig, multisig). Without it, there will be hard to see the Mir arsenal and evolution.
matejpavlovic
force-pushed
the
availability-rebased
branch
2 times, most recently
from
5901bbb
to
ace0efa
Compare
matejpavlovic
changed the title
Signed-off-by: Matej Pavlovic <[email protected]>
A special logger useful for testing. Its log entries can later be checked against a reference. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
This is an intermediate commit, the system does not work in this state. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Nil certificates are produced by the PBFT view change for padding. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
The buffer size introduced in the params will be used later for buffering early messages. Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
availability-rebased
branch
from
da18536
to
bb178ff
Compare
xosmig
reviewed
Aug 23, 2022
xosmig
reviewed
Aug 23, 2022
matejpavlovic
force-pushed
the
availability-rebased
branch
from
7cf7593
to
35f4f53
Compare
xosmig
reviewed
Aug 23, 2022
xosmig
reviewed
Aug 23, 2022
xosmig
reviewed
Aug 23, 2022
xosmig
reviewed
Aug 23, 2022
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
availability-rebased
branch
from
35f4f53
to
2d14f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch uses the availability module instead of directly submitting requests to ISS.
The availability module still uses a static configuration though, so reconfiguration is not yet supported on this branch.