Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standard build targets #18

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Add standard build targets #18

merged 1 commit into from
Sep 21, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Sep 21, 2020

No description provided.

@iand iand requested a review from placer14 September 21, 2020 10:58
@olizilla
Copy link
Contributor

I'm working on this as part of filecoin-project/sentinel#141 so am gonna merge this and update my local branch.

olizilla
olizilla approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olizilla
Copy link
Contributor

Ugh. I don't have permissions on this repo.

@iand iand force-pushed the iand/makefile-build branch 2 times, most recently from 16cc64e to f9f62d5 Compare September 21, 2020 11:11
@olizilla olizilla mentioned this pull request Sep 21, 2020
Merged
@olizilla
Copy link
Contributor

@iand please eyeball #19

@iand iand merged commit 47b1885 into master Sep 21, 2020
@iand iand deleted the iand/makefile-build branch September 21, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@placer14 placer14 Awaiting requested review from placer14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iand @olizilla