Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docker build and make targets #19

Merged
merged 7 commits into from
Sep 21, 2020

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Sep 21, 2020

  • add Dockerfile to build filecoin/sentinel-visor docker image
  • add make targets to build filecoin-ffi and sentinel-visor
  • add .dockerignore to reduce context sent to docker build

Updated to use standard make targets from @iand in #18

WIP on filecoin-project/sentinel#141

License: MIT
Signed-off-by: Oli Evans [email protected]

- add Dockerfile to build `filecoin/sentinel-visor` docker image
- add make targets to build filecoin-ffi and sentinel-visor
- add .dockerignore to reduce context sent to docker build

License: MIT
Signed-off-by: Oli Evans <[email protected]>
License: MIT
Signed-off-by: Oli Evans <[email protected]>
@iand iand self-requested a review September 21, 2020 12:26
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit

.dockerignore Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@olizilla olizilla merged commit 4586d9b into filecoin-project:master Sep 21, 2020
@olizilla olizilla deleted the docker-build branch September 21, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants