fix(migrations): CREATE EXTENSION deadlocks inside migrations global lock #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#179 says that this should documented to be run manually, but I find that suboptimal vs just doing it for the user (doing it when it's not needed does not seem like a bad thing either). If I'm missing something, let me know. |
iand
reviewed
Nov 9, 2020
Run this statement directly, as it seems it cannot be run inside a transaction.
hsanjuan
force-pushed
the
fix/179-remove-create-extension-from-migration
branch
from
544d0fa
to
39f3611
Compare
iand
reviewed
Nov 11, 2020
iand
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, run this statement before obtaining the global lock for migrations.
Fixes #179 .