chore: push docker tags from ci #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds script and ci config to push to docker hub when - the master or main branch changes - semver like tags are pushed to the repo Pushing a semver like tag pushes a docker image with the same tag. The docker latest tag points to the last semver version tag Pushing changes to main or master gets you a docker tag of the form <branch name>-<date>-<truncated commit sha> e.g main-2020-f435621. a <branch>-latest docker tag is provided as a convenince if you really want the bleeding edge. The branch name is included in the docker tag name to make that clearer. This is a tweak on what I set up for go-ipfs in ipfs/kubo#6949 License: MIT Signed-off-by: Oli Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds script and ci config to push to docker hub when.
Pushing a semver like tag pushes a docker image with the same tag. The docker latest tag points to the last semver version tag
Pushing changes to main or master gets you a docker tag of the form --
e.g main-2020-f435621. a -latest docker tag is provided as a convenince if you really want the bleeding edge. The branch name is included in the docker tag name to make that clearer.
This is a tweak on what I set up for go-ipfs in ipfs/kubo#6949
This PR is motivated by the fact that dockerhub has repeatedly been a time sink, and it's latest issue is that our docker builds fail there when we try to init the git submodules, which is not a problem locally or on circleci. The suggested docker hub hooks fix in #22 did not solve it, so here we take back control and push the docker image we were building anyway to the hub.
License: MIT
Signed-off-by: Oli Evans [email protected]