Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): add go mod tidy check #266

Merged
merged 2 commits into from
Nov 25, 2020
Merged

build(ci): add go mod tidy check #266

merged 2 commits into from
Nov 25, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 25, 2020

No description provided.

@frrist frrist force-pushed the frrist/go-mod-tidy branch 2 times, most recently from f93060e to 9295115 Compare November 25, 2020 21:54
@willscott
Copy link
Contributor

prefer doing this in the CI task, or as a github action?

@frrist
Copy link
Member Author

frrist commented Nov 25, 2020

I don't have a strong opinion on either. I've gone with circleCI here since there is prior art for this type of thing in Lotus and Specs-Actors. What do you think?

@frrist frrist force-pushed the frrist/go-mod-tidy branch 2 times, most recently from 612024f to a7d6dd9 Compare November 25, 2020 22:05
@willscott
Copy link
Contributor

seems reasonable

@frrist frrist force-pushed the frrist/go-mod-tidy branch 5 times, most recently from 52b81cf to 7b84c53 Compare November 25, 2020 22:22
@frrist
chore: run go mod tidy
f34b87e 
(should pass CI this time)
@frrist frrist merged commit 5bef7da into master Nov 25, 2020
@frrist frrist deleted the frrist/go-mod-tidy branch November 25, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frrist @willscott