feat: extract basic account actor states #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
reviewed
Nov 30, 2020
|
Extracting the basic state for all actors will have a time and storage cost and querying the table will become more difficult due to the amount of data. Given sentinel's remit perhaps this is acceptable and necessary? |
|
I would prefer to modify the
Is this a hunch or have we observed this to be the case with the |
|
I've modified so that it collects basic state for all account actors. |
frrist
approved these changes
Nov 30, 2020
tasks/actorstate/account.go
Outdated
| type AccountExtractor struct{} | ||
|
|
||
| func init() { | ||
| Register(builtin.AccountActorCodeID, AccountExtractor{}) |
There was a problem hiding this comment.
Register the account actor v1 codeID in addition to the v2 (this) one.
alanshaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Sentinel to persist state for the burnt funds actor without having to extract and persist data for ALL accounts.It registers anAccountExtractorfor the Account Actor CID and introduces the concept of aFilteredExtractor. If an extractor is aFilteredExtractorthenprocessActorwill call it'sFiltermethod to see if it wants to extract data for a given actor.At the moment theAccountExtractoris only interested in the burnt funds account and has no specialized extraction needs beyond what is automatically extracted by the common extractor. It means it'sExtractmethod is basically a noop.This PR adds an account actor extractor so that basic state is extracted for account actors.