perf: replace local state diffing with StateChangeActors API method #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
force-pushed
the
iand/actor-state-api
branch
from
4fbdeee
to
06714be
Compare
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
======================================
Coverage 44.9% 44.9%
======================================
Files 20 20
Lines 1978 1978
======================================
Hits 890 890
Misses 969 969
Partials 119 119 |
frrist
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the recent analysis of API usage this change saves us over 9000 roundtrips to lotus with a corresponding performance gain.