Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: table and column comments #346

Merged
merged 29 commits into from
Jan 26, 2021
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jan 6, 2021

Documentation for visor tables and their columns.

resolves #223

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #346 (0f3dc39) into master (56d31f3) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #346   +/-   ##
======================================
  Coverage    42.2%   42.2%           
======================================
  Files          25      25           
  Lines        1896    1896           
======================================
  Hits          802     802           
  Misses        967     967           
  Partials      127     127           

@frrist
Copy link
Member

frrist commented Jan 6, 2021

Is the intent of this change to address #223? Love this by the way!

@alanshaw alanshaw marked this pull request as ready for review January 26, 2021 11:17
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alanshaw alanshaw merged commit dcc3c57 into master Jan 26, 2021
@alanshaw alanshaw deleted the feat/table-and-column-comments branch January 26, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document visor schema
5 participants