feat: record multisig approvals #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
========================================
+ Coverage 42.9% 46.4% +3.5%
========================================
Files 25 24 -1
Lines 1940 1796 -144
========================================
+ Hits 833 835 +2
+ Misses 980 834 -146
Partials 127 127 |
frrist
approved these changes
Feb 17, 2021
| "to" text not null, | ||
| "value" numeric not null, | ||
| "signers" jsonb not null, | ||
| PRIMARY KEY ("height", "state_root", "multisig_id") |
There was a problem hiding this comment.
Based on the definition of the MultisigApproval model (which I believe to be correct) Approver and Message should be primary keys here.
tasks/msapprovals/msapprovals.go
Outdated
| default: | ||
| } | ||
|
|
||
| // ll.Infow("found message", "to", m.ToActorCode.String(), "addr", m.Message.To.String()) |
lens/lotus/api.go
Outdated
Comment on lines
245
to
250
| if err == nil && !found { | ||
| return cid.Undef | ||
| } | ||
| if err != nil { | ||
| return cid.Undef | ||
| } |
There was a problem hiding this comment.
if err != nil || !found {
return cid.Undef
}is a tad clearer imo.
frrist
added a commit
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and populate a new
multisig_approvalstable containing multisig transaction approvals derived from propose and approve messages sent to the multisig actor. Create a new task calledmsapprovalsto run the extraction.Refactored the message task and moved it under the tasks package and then created a msapprovals package as a sibling. Ideally I would like to see all the named tasks move in this way so the chain package just contains chain walking/watching logic.
Anecdotally the
msapprovalstask takes a few seconds to run per tipset, depending on the number of multisig messages.(apologies for the dozens of hacky commits which I needed for shipping code for intractive testing - will squash them anyway before merge)
Fixes #388