fix: msapprovals missing pending transaction #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
approved these changes
Feb 19, 2021
| act, err := p.node.StateGetActor(ctx, msg.To, pts.Key()) | ||
| // pts is the tipset containing the messages, so we need the state as seen at the start of message processing | ||
| // for that tipset | ||
| act, err := p.node.StateGetActor(ctx, msg.To, pts.Parents()) |
There was a problem hiding this comment.
Did some underlying behaviour change that now we need to use the parents?
There was a problem hiding this comment.
No, but pts is the tipset containing the message, so we need to look at the actor state before the message was applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394