Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace panic with error return in indexer.Start #4

Merged
merged 1 commit into from
Sep 16, 2020
Merged

refactor: replace panic with error return in indexer.Start #4

merged 1 commit into from
Sep 16, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Sep 15, 2020

No description provided.

@iand iand requested a review from frrist September 15, 2020 22:14
@iand iand self-assigned this Sep 15, 2020
placer14
placer14 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iand iand merged commit 81ee812 into master Sep 16, 2020
@iand iand deleted the iand/refactor-indexer branch September 16, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placer14 placer14 placer14 approved these changes

@frrist frrist Awaiting requested review from frrist

Assignees

@iand iand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iand @placer14