chore: add tests for reward and power actor state extracters #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
force-pushed
the
iand/actorstate-further-tests
branch
from
5fa4170
to
38b0e38
Compare
placer14
approved these changes
Oct 11, 2020
tasks/actorstate/power_test.go
Outdated
| state.TotalPledgeCollateral = abi.NewTokenAmount(0) | ||
| state.ThisEpochRawBytePower = abi.NewStoragePower(0) | ||
| state.ThisEpochQualityAdjPower = abi.NewStoragePower(0) | ||
| state.ThisEpochPledgeCollateral = abi.NewTokenAmount(0) |
There was a problem hiding this comment.
Going to add some values here to make sure we don't get false positives due to zero values conveniently matching our test data.
placer14
reviewed
Oct 11, 2020
| assert.EqualValues(t, info.ParentStateRoot.String(), cr.StateRoot, "StateRoot") | ||
| assert.EqualValues(t, state.CumsumBaseline.String(), cr.CumSumBaseline, "CumSumBaseline") | ||
| // TODO: assertion fails due to bug in lotus see https://github.com/filecoin-project/lotus/pull/4268 | ||
| // assert.EqualValues(t, state.CumsumRealized.String(), cr.CumSumRealized, "CumSumRealized") |
There was a problem hiding this comment.
Ahh... beautiful! Nice find!
placer14
force-pushed
the
iand/actorstate-further-tests
branch
from
9d05123
to
f53a7f7
Compare
|
Rebased onto latest master to make it more obvious what is being changed in this PR. |
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
* origin/master: fix: remove errgrp from UnindexedBlockData persist fix: verify there are no missing migrations before migrating (#89) chore: add tests for reward and power actor state extracters (#83) feat: support v2 actor codes (#84) feat(debug): Process actor by head without persistance (#86) fix: use debugf logging method in message processor (#82) feat(task): Create chainvis views and refresher (#77) perf: minor optimization of market actor diffing (#78) chore: fail database tests if VISOR_TEST_DB not set (#79) test(storage): add test to check for duplicate schema migrations (#80) in-process lotus "repo" lens (#75) Conflicts: tasks/actorstate/miner.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this branched from #81