Runtime.CreateActor can only be used by the init actor?

[alanshaw]

I noticed that Runtime.CreateActor should only be used by the init actor:

specs-actors/actors/runtime/runtime.go

Lines 103 to 106 in c9027ee

	// Creates an actor with code `codeID` and address `address`, with empty state.
	// May only be called by Init actor.
	// Aborts if the provided address has previously been created.
	CreateActor(codeId cid.Cid, address addr.Address)

There are no checks in lotus that this happens (see here) and it looks like go-filecoin did not check either.

Should there be an assertion within Runtime.CreateActor that the caller is the init actor?...and should there be a test in test-vectors to verify this is the case?

If yes to the above then we have a problem right now with the chaos actor because it has a CreateActor method that calls Runtime.CreateActor directly to test other behaviours and it's only able to do so because of a bug 😱.

cc @filecoin-project/oni

[anorth]

Yes, there should be a check in Lotus (aborting with SysErrIllegalActor).