Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for xml column type #16

Open
brentweber opened this issue Jul 5, 2017 · 4 comments
Open

support for xml column type #16

brentweber opened this issue Jul 5, 2017 · 4 comments

Comments

@brentweber
Copy link

I was wondering if you have plans to support xml column type, even if it just returns it as a string. I get the following error when attempting to use this column in my schema as the :string type
** (Mssqlex.Error) Column type not supported | ODBC_CODE | SQL_SERVER_CODE 0

@shdblowers
Copy link
Collaborator

Hi @brentweber I will look into whether supporting this requires a change to msql_ecto or a change to Erlang ODBC

@shdblowers
Copy link
Collaborator

Hi @brentweber have investigated supporting XML type and will require a change to Erlang ODBC rather than mssql_ecto or mssqlex.

@toddharding is currently looking at making a change to Erlang ODBC to support datetimeoffset, I wonder if it would be possible to support xml via a similar change?

@shdblowers
Copy link
Collaborator

Leaving this here for future reference.

Testing XML type.

test "xml", %{pid: pid} do
    assert {_query, %Result{columns: ["test"], rows: [["<message>Hello</message>"]]}} =
      act(pid, "xml", ["<message>Hello</message>"])
  end

@brentweber
Copy link
Author

@shdblowers thanks for looking into this, and if @toddharding would be able to support XML type via a similar ODBC change that would be great but after further testing I'm not sure I will be able to use this adapter due to string type limitations. But Im sure someone will have the XML issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants