Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable insertion misalignment #9

Merged
merged 2 commits into from
May 23, 2018
Merged

Variable insertion misalignment #9

merged 2 commits into from
May 23, 2018

Conversation

shdblowers
Copy link
Collaborator

Adding test coverage around variable insertion with WHERE IN clauses to help diagnose findmypast-oss/mssql_ecto#18

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.553% when pulling 9b3431b on variable_insertion_misalignment into cbe05ec on master.

@shdblowers shdblowers mentioned this pull request Jul 13, 2017
Open
@shdblowers shdblowers merged commit 837ca45 into master May 23, 2018
@shdblowers
Copy link
Collaborator Author

didn't unearth bug, but extra tests are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shdblowers @coveralls