Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_auth ] State of MFA #7290

Closed
MSchmack opened this issue Nov 2, 2021 · 22 comments
Closed

[firebase_auth ] State of MFA #7290

MSchmack opened this issue Nov 2, 2021 · 22 comments
Assignees
Labels
plugin: auth resolution: fixed A fix has been merged or is pending merge from a PR. type: question A question where further information is requested

Comments

@MSchmack
Copy link

MSchmack commented Nov 2, 2021

Firebase_auth MFA is currently the second highest unanswered feature request and open since august 2020 without a reply. Google brands flutter as first class citizen but this core feature seems to be getting ignored. As good as any application aimed at mid to enterprise sized organizations that is hosted outside of intranets utilizes 2-factor / MFA auth.

This isn't a issue in the usual sense but a statement on if this feature will find its way into the packages is important for any future app that otherwise will have to look into a seperate solution or workaround for this as well as other potentially missing features.

image

Edit: Accidentally added the wrong labels. The labels can be removed.

@MSchmack MSchmack added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Nov 2, 2021
@darshankawar darshankawar added the triage Issue is currently being triaged. label Nov 2, 2021
@darshankawar
Copy link

Keeping this issue open and will try to forward this to the team for their insights on this.

@darshankawar darshankawar added plugin: auth type: question A question where further information is requested and removed type: bug Something isn't working Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Nov 2, 2021
@darshankawar
Copy link

related discussion thread: #2386

@darshankawar
Copy link

/cc @Ehesp

@Ehesp Ehesp self-assigned this Nov 10, 2021
@steeling
Copy link

This feature has been around for over a year outside of Flutter.. any updates?

@steeling
Copy link

FWIW it looks like this feature would take all of 4 API calls to implement:

START_PHONE_MFA_ENROLLMENT = '/v2/accounts/mfaEnrollment:start',
FINALIZE_PHONE_MFA_ENROLLMENT = '/v2/accounts/mfaEnrollment:finalize',
START_PHONE_MFA_SIGN_IN = '/v2/accounts/mfaSignIn:start',
FINALIZE_PHONE_MFA_SIGN_IN = '/v2/accounts/mfaSignIn:finalize',

@Ehesp
Copy link
Member

Ehesp commented Nov 18, 2021

Hi All - this is on the roadmap, but currently we are prioritising releasing the remaining plugins. Once they're complete, this will be worked on.

@dominicmh
Copy link

Hi @Ehesp, is the roadmap for this feature clearer now that the remaining plugins have been released?
Thanks!

@hansanker
Copy link

hansanker commented Jan 13, 2022

Hi, I hope this feature comes soon. We need MFA in our application to be compliant. Thanks a lot in advance.
And thanks for the work done so far on flutterfire, it has been a great help!

@Ehesp
Copy link
Member

Ehesp commented Jan 13, 2022

@Salakar is currently documenting the API surface area for all platforms. Once that is approved we'll start the implementation.

@cbenhagen
Copy link
Contributor

@Salakar is that documentation public somewhere? What is the status of the implementation? How can I help?

@davidmigloz
Copy link

@Ehesp do you have an approx. ETA?
I'm willing to help if needed.

@Lyokone
Copy link
Contributor

Lyokone commented Jun 20, 2022

Hey, the implementation is in progress.
Was needing the v9 SDK on JS that should be soon ready. Thanks for your patience

@mufarrah
Copy link

Any updates on this ?

@Lyokone
Copy link
Contributor

Lyokone commented Jul 20, 2022

Should be release with this week version

@mufarrah
Copy link

Should be release with this week version

Awesome, looking forward

@cbenhagen
Copy link
Contributor

@Lyokone great news! Will there also be macOS support? What about Linux / Windows in https://github.com/invertase/flutterfire_desktop?

@Lyokone
Copy link
Contributor

Lyokone commented Jul 20, 2022

macOS support will not be integrated at first. The underlying Firebase macOS SDK is missing some functions.

Not sure about Linux / Windows, the REST API doesn't seem to support MFA 🤔
https://firebase.google.com/docs/reference/rest/auth

@cbenhagen
Copy link
Contributor

@Lyokone can you be more specific about the missing functions in the macOS SDK? Is there an open issue already you can link to? I have successfully implemented MFA on macOS in our app using the REST API. You can find the documentation here:
https://cloud.google.com/identity-platform/docs/reference/rest/v2/accounts.mfaEnrollment

And some more info in this discussion: #2386

@Lyokone
Copy link
Contributor

Lyokone commented Jul 20, 2022

As I remember, the verifyPhone function was missing from the macOS SDK, I might need to double-check that.
Thanks for the documentation, we'll probably focus on Android, iOS and Web then add desktop platforms.

@cbenhagen
Copy link
Contributor

@Lyokone Are you refering to -verifyphonenumber:uidelegate:completion:? Would you mind creating an issue in https://github.com/firebase/firebase-ios-sdk for the missing functions once you tracked them down?

@Lyokone
Copy link
Contributor

Lyokone commented Jul 21, 2022

Hey,
I doubled checked and even MultiFactorSession is only available for iOS : https://firebase.google.com/docs/reference/ios/firebaseauth/api/reference/Classes#firmultifactorsession

I've added a request here: firebase/firebase-ios-sdk#10034

@russellwheatley russellwheatley assigned Lyokone and unassigned Ehesp Aug 16, 2022
@Lyokone Lyokone closed this as completed Oct 6, 2022
@Lyokone
Copy link
Contributor

Lyokone commented Oct 6, 2022

Closing since MFA is now available

@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR. label Oct 6, 2022
@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: auth resolution: fixed A fix has been merged or is pending merge from a PR. type: question A question where further information is requested
Projects
None yet
Development

No branches or pull requests

10 participants