Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

version debugger #2292

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Conversation

jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Mar 6, 2017

Summary of Changes

  • bump debugger to version 0.1.0
  • add a module manifest for consistent bundles so our modules don't bounce around in the bundle. Thanks @TheLarkInn for the tip!

@juliandescottes

Copy link
Member

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module manifest seems like a great improvement if it works!

Regarding the version bump I guess it makes sense to do it now given the current situation.

I'd find it more useful if this tag was actually the exact version that landed in mozilla-central. Here I know we have accepted PRs between the bundle that got into mozilla-central and this 0.1.0 version bump.

So for the next release I'd advise creating a branch when we want to release to mc, bump the version there, create a bundle and iterate on this branch in order to get something landable (I am heavily biased since it's what I do for reps :) https://github.com/devtools-html/reps/blob/master/RELEASE.md )

@jasonLaster
Copy link
Contributor Author

jasonLaster commented Mar 6, 2017

the manifest works. and it is amazing. The 70K debugger.js diff we had would have been 5K had it used the manifest. that's a big savings

yeah, true. we could always push to it before it lands

@jasonLaster jasonLaster merged commit bcba4e5 into firefox-devtools:master Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants