Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.0 fixes around database quoting and rendering #1332

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

drewbanin
Copy link
Contributor

  • do not quote snowflake database identifiers by default (preserves <=0.12.2 behavior)
  • do not find relations in source schemas in list_relations (strictly to speed up parsing -- is the mechanism shown here an acceptable way to accomplish this?)
  • do not render database names in stdout if a custom database is not specified (aesthetics)

I took some liberties here to round out the rest of the feedback around the 0.13.0 prerelease, but happy to discuss or revisit any of these!

- do not quote snowflake database identifiers by default
- do not find relations in source schemas in list_relations
- do not render database names in stdout if a custom database is not specified
@drewbanin drewbanin requested a review from beckjake March 4, 2019 14:11
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (edit: once the missing import is in/tests pass)

@drewbanin
Copy link
Contributor Author

This is failing due to the changes required in #1326

By turning quoting off for databases on Snowflake, the catalog query now looks like:

         select *
            from tables
            join columns using ("table_database", "table_schema", "table_name")
            where "table_schema" != 'INFORMATION_SCHEMA'
              and "table_database" = DBT_TEST_ALT --- <---- this is not quoted
            order by "column_index"

So, let's fix 1326 then merge it in here

@beckjake beckjake merged commit 7eb033e into dev/stephen-girard Mar 6, 2019
@beckjake beckjake deleted the snowflake-unquote-db-by-default-2 branch March 6, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants